]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ice: Fix call trace on suspend
authorAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Wed, 2 Sep 2020 15:53:45 +0000 (08:53 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 25 Sep 2020 14:39:24 +0000 (07:39 -0700)
It appears that the ice_suspend flow is missing a call to pci_save_state
and this is triggering the message "State of device not saved by
ice_suspend" and a call trace. Fix it.

Fixes: 769c500dcc1e ("ice: Add advanced power mgmt for WoL")
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c

index 4634b48949bb7a125b4ce319546d2c5eafd5a90a..954f11f86f505f5b903c1ebebfb435d2bd6d2e1d 100644 (file)
@@ -4522,6 +4522,7 @@ static int __maybe_unused ice_suspend(struct device *dev)
        }
        ice_clear_interrupt_scheme(pf);
 
+       pci_save_state(pdev);
        pci_wake_from_d3(pdev, pf->wol_ena);
        pci_set_power_state(pdev, PCI_D3hot);
        return 0;