USB: serial: garmin_gps: fix memory leak on probe errors

BugLink: http://bugs.launchpad.net/bugs/1744212
commit 74d471b598444b7f2d964930f7234779c80960a0 upstream.

Make sure to free the port private data before returning after a failed
probe attempt.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index c72ffbd913adb40e97e00160af3762102a233c02..91e7e3a166a5cde158ac1b99b5f8b9f5d1f3ee10 100644 (file)
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -1413,6 +1413,12 @@ static int garmin_port_probe(struct usb_serial_port *port)
        usb_set_serial_port_data(port, garmin_data_p);
 
        status = garmin_init_session(port);
+       if (status)
+               goto err_free;
+
+       return 0;
+err_free:
+       kfree(garmin_data_p);
 
        return status;
 }