]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
Input: pixcir_i2c_ts - fix receive error
authorFrodo Lai <frodo.lai@gmail.com>
Tue, 16 Jun 2015 22:03:53 +0000 (15:03 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 17 Jun 2015 00:11:27 +0000 (17:11 -0700)
The i2c_master_recv() uses readsize to receive data from i2c but compares
to size of rdbuf which is always 27. This would cause problem when the
max_fingers is not 5. Change the comparison value to readsize instead.

Fixes: 36874c7e219 ("Input: pixcir_i2c_ts - support up to 5 fingers and
hardware tracking IDs:)

Cc: stable@vger.kernel.org
Signed-off-by: Frodo Lai <frodo_lai@bcmcom.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/pixcir_i2c_ts.c

index 2c2107147319ed1e017353e577e3f75df0f5496c..8f3e243a62bf3a7930a83fede8c24377252fdfba 100644 (file)
@@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata,
        }
 
        ret = i2c_master_recv(tsdata->client, rdbuf, readsize);
-       if (ret != sizeof(rdbuf)) {
+       if (ret != readsize) {
                dev_err(&tsdata->client->dev,
                        "%s: i2c_master_recv failed(), ret=%d\n",
                        __func__, ret);