]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:29:02 +0000 (22:29 +0100)
committerAndrea Righi <andrea.righi@canonical.com>
Mon, 15 Mar 2021 14:08:52 +0000 (15:08 +0100)
[ Upstream commit 1fea2eb2f5bbd3fbbe2513d2386b5f6e6db17fd7 ]

The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Fixes: 9589f7721e16 ("arm64: dts: Add S2MPS15 PMIC node on exynos7-espresso")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212903.216728-8-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
arch/arm64/boot/dts/exynos/exynos7-espresso.dts

index 695d4c14064666cecd6872143e0bb752f26aa498..125c03f351d97c48e075b730303b051e771a75a0 100644 (file)
@@ -90,7 +90,7 @@
        pmic@66 {
                compatible = "samsung,s2mps15-pmic";
                reg = <0x66>;
-               interrupts = <2 IRQ_TYPE_NONE>;
+               interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
                interrupt-parent = <&gpa0>;
                pinctrl-names = "default";
                pinctrl-0 = <&pmic_irq>;