]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
cdc-acm: cleanup debugging in submission path
authorOliver Neukum <oneukum@suse.com>
Tue, 13 Sep 2016 14:44:36 +0000 (16:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Sep 2016 15:24:24 +0000 (17:24 +0200)
Actually make it retutn useful information.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c

index fef0d8fcd91646b89d1f081c40c129f1faf957c7..faab151d9fdccc9525f77556f0cbcfe138ff2d1e 100644 (file)
@@ -368,17 +368,17 @@ static int acm_submit_read_urb(struct acm *acm, int index, gfp_t mem_flags)
        if (!test_and_clear_bit(index, &acm->read_urbs_free))
                return 0;
 
-       dev_vdbg(&acm->data->dev, "%s - urb %d\n", __func__, index);
-
        res = usb_submit_urb(acm->read_urbs[index], mem_flags);
        if (res) {
                if (res != -EPERM) {
                        dev_err(&acm->data->dev,
-                                       "%s - usb_submit_urb failed: %d\n",
-                                       __func__, res);
+                                       "urb %d failed submission with %d\n",
+                                       index, res);
                }
                set_bit(index, &acm->read_urbs_free);
                return res;
+       } else {
+               dev_vdbg(&acm->data->dev, "submitted urb %d\n", index);
        }
 
        return 0;