]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 19 Oct 2023 17:34:55 +0000 (20:34 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 20 Oct 2023 09:24:16 +0000 (11:24 +0200)
When refactoring the acpi_get_gpiod_from_data() the change missed
cleaning up the variable on stack. Add missing memset().

Reported-by: Ferry Toth <ftoth@exalondelft.nl>
Fixes: 16ba046e86e9 ("gpiolib: acpi: teach acpi_find_gpio() to handle data-only nodes")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib-acpi.c

index fbda452fb4d6afd4154d4f9e219b3b0cfb434e1a..51e41676de0b8df597a7d9afd493165863e5b053 100644 (file)
@@ -951,6 +951,7 @@ static struct gpio_desc *acpi_get_gpiod_from_data(struct fwnode_handle *fwnode,
        if (!propname)
                return ERR_PTR(-EINVAL);
 
+       memset(&lookup, 0, sizeof(lookup));
        lookup.index = index;
 
        ret = acpi_gpio_property_lookup(fwnode, propname, index, &lookup);