]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
HID: hid-lg: make array cbuf static const to shink object code size
authorColin Ian King <colin.king@canonical.com>
Fri, 25 Aug 2017 17:12:50 +0000 (18:12 +0100)
committerJiri Kosina <jkosina@suse.cz>
Wed, 6 Sep 2017 08:58:54 +0000 (10:58 +0200)
Don't populate array cbuf on the stack, instead make it static.
Makes the object code smaller by over 110 bytes:

Before:
   text    data     bss     dec     hex filename
  15096    3504     128   18728    4928 drivers/hid/hid-lg.o

After:
   text    data     bss     dec     hex filename
  14884    3600     128   18612    48b4 drivers/hid/hid-lg.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-lg.c

index 52026dc94d5c4b0306ce585be293cbe2cb1910d9..596227ddb6e078af028b2d83102d40e5006b147a 100644 (file)
@@ -756,7 +756,9 @@ static int lg_probe(struct hid_device *hdev, const struct hid_device_id *id)
 
        /* Setup wireless link with Logitech Wii wheel */
        if (hdev->product == USB_DEVICE_ID_LOGITECH_WII_WHEEL) {
-               const unsigned char cbuf[] = { 0x00, 0xAF,  0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
+               static const unsigned char cbuf[] = {
+                       0x00, 0xAF,  0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
+               };
                u8 *buf = kmemdup(cbuf, sizeof(cbuf), GFP_KERNEL);
 
                if (!buf) {