]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/radeon: Fix integer overflow in radeon_cs_parser_init
authorhackyzh002 <hackyzh002@gmail.com>
Wed, 19 Apr 2023 12:20:58 +0000 (20:20 +0800)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Mon, 2 Oct 2023 15:20:34 +0000 (17:20 +0200)
BugLink: https://bugs.launchpad.net/bugs/2037005
[ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ]

The type of size is unsigned, if size is 0x40000000, there will be an
integer overflow, size will be zero after size *= sizeof(uint32_t),
will cause uninitialized memory to be referenced later

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
drivers/gpu/drm/radeon/radeon_cs.c

index 46a27ebf4588a2241d4ab7f8f00be4b8ebff9057..a6700d7278bf3ee6967c8a43e67922ae436a5f49 100644 (file)
@@ -270,7 +270,8 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
 {
        struct drm_radeon_cs *cs = data;
        uint64_t *chunk_array_ptr;
-       unsigned size, i;
+       u64 size;
+       unsigned i;
        u32 ring = RADEON_CS_RING_GFX;
        s32 priority = 0;