]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
clk: imx31: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 21 Oct 2015 20:41:39 +0000 (22:41 +0200)
committerStephen Boyd <sboyd@codeaurora.org>
Wed, 21 Oct 2015 23:16:34 +0000 (16:16 -0700)
for_each_compatible_node performs an of_node_get on each iteration, so a
break out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e;
@@

 for_each_compatible_node(n,...) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/imx/clk-imx31.c

index f65b8b1a974ac4b3d91be2d5af87d904d13c3e70..6a964144a5b5df1d3d134e22bfcd8464f510e6a3 100644 (file)
@@ -233,8 +233,10 @@ int __init mx31_clocks_init_dt(void)
                if (!of_device_is_compatible(np, "fsl,imx-osc26m"))
                        continue;
 
-               if (!of_property_read_u32(np, "clock-frequency", &fref))
+               if (!of_property_read_u32(np, "clock-frequency", &fref)) {
+                       of_node_put(np);
                        break;
+               }
        }
 
        _mx31_clocks_init(fref);