]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: stmmac: dwmac-generic: add missing compatible strings
authorNiklas Cassel <niklas.cassel@axis.com>
Wed, 7 Dec 2016 12:41:07 +0000 (13:41 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Dec 2016 16:35:37 +0000 (11:35 -0500)
devicetree binding for stmmac states:
- compatible: Should be "snps,dwmac-<ip_version>", "snps,dwmac"
For backwards compatibility: "st,spear600-gmac" is also supported.

Since dwmac-generic.c calls stmmac_probe_config_dt explicitly,
another alternative would have been to remove all compatible strings
other than "snps,dwmac" and "st,spear600-gmac" from dwmac-generic.c.

However, that would probably do more good than harm, since when trying
to figure out what hardware a certain driver supports, you usually look
at the compatible strings in the struct of_device_id, and not in some
function defined in a completely different file.

No functional change intended.

Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c

index e6e6c2fcc4b77b7bffcc8201dc4b64bbbbdd1916..3304095c934c393582a19e135d8faade1ad4ba75 100644 (file)
@@ -71,9 +71,12 @@ err_remove_config_dt:
 
 static const struct of_device_id dwmac_generic_match[] = {
        { .compatible = "st,spear600-gmac"},
+       { .compatible = "snps,dwmac-3.50a"},
        { .compatible = "snps,dwmac-3.610"},
        { .compatible = "snps,dwmac-3.70a"},
        { .compatible = "snps,dwmac-3.710"},
+       { .compatible = "snps,dwmac-4.00"},
+       { .compatible = "snps,dwmac-4.10a"},
        { .compatible = "snps,dwmac"},
        { }
 };