vhost: fix vhost_vq_access_ok() log check

BugLink: http://bugs.launchpad.net/bugs/1769723
[ Upstream commit d14d2b78090c7de0557362b26a4ca591aa6a9faa ]

Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log
when IOTLB is enabled") introduced a regression.  The logic was
originally:

  if (vq->iotlb)
      return 1;
  return A && B;

After the patch the short-circuit logic for A was inverted:

  if (A || vq->iotlb)
      return A;
  return B;

This patch fixes the regression by rewriting the checks in the obvious
way, no longer returning A when vq->iotlb is non-NULL (which is hard to
understand).

Reported-by: syzbot+65a84dde0214b0387ccd@syzkaller.appspotmail.com
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index a5622a8364cbef97887069190857f2abc3bb33d8..7f828cc5941f9644666a3373b84e2cb49430fde3 100644 (file)
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1256,10 +1256,12 @@ static int vq_log_access_ok(struct vhost_virtqueue *vq,
 /* Caller should have vq mutex and device mutex */
 int vhost_vq_access_ok(struct vhost_virtqueue *vq)
 {
-       int ret = vq_log_access_ok(vq, vq->log_base);
+       if (!vq_log_access_ok(vq, vq->log_base))
+               return 0;
 
-       if (ret || vq->iotlb)
-               return ret;
+       /* Access validation occurs at prefetch time with IOTLB */
+       if (vq->iotlb)
+               return 1;
 
        return vq_access_ok(vq, vq->num, vq->desc, vq->avail, vq->used);
 }