iio: adc: remove unused private data assigned with spi_set_drvdata()

These were usually used before the conversion to devm_ functions, so that
the remove hook would be able to retrieve the pointer and do cleanups on
remove.
When the conversion happened, they should have been removed, but were
omitted.

Some drivers were copied from drivers that fit the criteria described
above. In any case, in order to prevent more drivers from being used as
example (and have spi_set_drvdata() needlessly set), this change removes it
from the IIO ADC group.

Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Link: https://lore.kernel.org/r/20210513111035.77950-1-aardelean@deviqon.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
index 9d5a71df02b09f3c1ec109617812a7477daf3670..a1e8b32671cf612f2cb07197b87ac87cc596f2d1 100644 (file)
--- a/drivers/iio/adc/ad7476.c
+++ b/drivers/iio/adc/ad7476.c
@@ -389,8 +389,6 @@ static int ad7476_probe(struct spi_device *spi)
        if (IS_ERR(st->convst_gpio))
                return PTR_ERR(st->convst_gpio);
 
-       spi_set_drvdata(spi, indio_dev);
-
        st->spi = spi;
 
        indio_dev->name = spi_get_device_id(spi)->name;

diff --git a/drivers/iio/adc/ad7766.c b/drivers/iio/adc/ad7766.c
index 9b35c09b9313798efe72fcad00019721f79d89fe..51ee9482e0df90707fc6e1ad68310dc899d6011e 100644 (file)
--- a/drivers/iio/adc/ad7766.c
+++ b/drivers/iio/adc/ad7766.c
@@ -273,8 +273,6 @@ static int ad7766_probe(struct spi_device *spi)
                        return ret;
        }
 
-       spi_set_drvdata(spi, indio_dev);
-
        ad7766->spi = spi;
 
        /* First byte always 0 */

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 4db3b480a871ab2a687923f7865896f48ef469ad..2c5c8a3672b2d5d28f9392e16ff8bcfaa8d599e5 100644 (file)
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -614,7 +614,6 @@ static int ad7768_probe(struct spi_device *spi)
 
        st->mclk_freq = clk_get_rate(st->mclk);
 
-       spi_set_drvdata(spi, indio_dev);
        mutex_init(&st->lock);
 
        indio_dev->channels = ad7768_channels;

diff --git a/drivers/iio/adc/ad7887.c b/drivers/iio/adc/ad7887.c
index 9b3cbe1ddc6f8660d52a56ad83618e90a43a6f23..f64999714a4da41ee2aa5d7abf55a1bae6a319b6 100644 (file)
--- a/drivers/iio/adc/ad7887.c
+++ b/drivers/iio/adc/ad7887.c
@@ -268,7 +268,6 @@ static int ad7887_probe(struct spi_device *spi)
        st->chip_info =
                &ad7887_chip_info_tbl[spi_get_device_id(spi)->driver_data];
 
-       spi_set_drvdata(spi, indio_dev);
        st->spi = spi;
 
        indio_dev->name = spi_get_device_id(spi)->name;

diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
index 19a45dd437967e882a1a441478df4ba1ee6c5870..dbfc8517cb8ab445143b467b22aaf79269b11707 100644 (file)
--- a/drivers/iio/adc/ad9467.c
+++ b/drivers/iio/adc/ad9467.c
@@ -434,8 +434,6 @@ static int ad9467_probe(struct spi_device *spi)
                mdelay(10);
        }
 
-       spi_set_drvdata(spi, st);
-
        conv->chip_info = &info->axi_adc_info;
 
        id = ad9467_spi_read(spi, AN877_ADC_REG_CHIP_ID);

diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
index 074c30970465ab045f3784ee3ffb97d3f9c11c2e..8b353e26668e263c4fcb7661aabde5e4106a378a 100644 (file)
--- a/drivers/iio/adc/hi8435.c
+++ b/drivers/iio/adc/hi8435.c
@@ -483,7 +483,6 @@ static int hi8435_probe(struct spi_device *spi)
                gpiod_set_value_cansleep(reset_gpio, 1);
        }
 
-       spi_set_drvdata(spi, idev);
        mutex_init(&priv->lock);
 
        idev->name              = spi_get_device_id(spi)->name;

diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
index e3c8ec107722da41816f01c9add38e9c84d1f346..655ab02d03d8496bf73cabb24898ba7a1b8c37db 100644 (file)
--- a/drivers/iio/adc/max1027.c
+++ b/drivers/iio/adc/max1027.c
@@ -430,8 +430,6 @@ static int max1027_probe(struct spi_device *spi)
                return -ENOMEM;
        }
 
-       spi_set_drvdata(spi, indio_dev);
-
        st = iio_priv(indio_dev);
        st->spi = spi;
        st->info = &max1027_chip_info_tbl[spi_get_device_id(spi)->driver_data];

diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c
index 0cbbb3c56d08a7de63dbc11fd1023c3f7f617a25..b60f8448f21a475832c3192f00544a89762033c4 100644 (file)
--- a/drivers/iio/adc/max1241.c
+++ b/drivers/iio/adc/max1241.c
@@ -147,8 +147,6 @@ static int max1241_probe(struct spi_device *spi)
        adc->spi = spi;
        mutex_init(&adc->lock);
 
-       spi_set_drvdata(spi, indio_dev);
-
        adc->vdd = devm_regulator_get(dev, "vdd");
        if (IS_ERR(adc->vdd)) {
                dev_err(dev, "failed to get vdd regulator\n");

diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c
index 33aea961d85088c38c89548ebdacaba29d7582af..ce3f5a3814f9027aa88d41d8e67bd7cb04ceb8d2 100644 (file)
--- a/drivers/iio/adc/ti-adc084s021.c
+++ b/drivers/iio/adc/ti-adc084s021.c
@@ -210,9 +210,6 @@ static int adc084s021_probe(struct spi_device *spi)
        adc = iio_priv(indio_dev);
        adc->spi = spi;
 
-       /* Connect the SPI device and the iio dev */
-       spi_set_drvdata(spi, indio_dev);
-
        /* Initiate the Industrial I/O device */
        indio_dev->name = spi_get_device_id(spi)->name;
        indio_dev->modes = INDIO_DIRECT_MODE;

diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
index b4a128b19188946a643cacd9a4450abb29b9300e..17d0da5877a9a6c0a46e82c9285e3fe26b02d8e9 100644 (file)
--- a/drivers/iio/adc/ti-ads124s08.c
+++ b/drivers/iio/adc/ti-ads124s08.c
@@ -327,8 +327,6 @@ static int ads124s_probe(struct spi_device *spi)
 
        ads124s_priv->chip_info = &ads124s_chip_info_tbl[spi_id->driver_data];
 
-       spi_set_drvdata(spi, indio_dev);
-
        ads124s_priv->spi = spi;
 
        indio_dev->name = spi_id->name;

diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
index cf5373d5cdd742e19c4d922811aff0ec3632e2e8..170950d5dd499101384f4e7f9d8cf52b09172ec9 100644 (file)
--- a/drivers/iio/adc/ti-tsc2046.c
+++ b/drivers/iio/adc/ti-tsc2046.c
@@ -639,8 +639,6 @@ static int tsc2046_adc_probe(struct spi_device *spi)
        priv = iio_priv(indio_dev);
        priv->dcfg = dcfg;
 
-       spi_set_drvdata(spi, indio_dev);
-
        priv->spi = spi;
 
        indio_dev->name = TI_TSC2046_NAME;