]> git.proxmox.com Git - mirror_ifupdown2.git/commitdiff
addons: bridge: ifquery -c fix for port attributes
authorNikhil <nikhil@cumulusnetworks.com>
Wed, 29 Jun 2016 23:38:50 +0000 (16:38 -0700)
committerNikhil <nikhil@cumulusnetworks.com>
Thu, 30 Jun 2016 17:17:31 +0000 (10:17 -0700)
Ticket: CM-11195
Reviewed By: roopa, julien
Testing Done: used the configuration mentioned in bug description

Signed-off-by: Nikhil <nikhil@cumulusnetworks.com>
running values for bridge-portmcrouter, bridge-portmcfl, and bridge-portprios
were accessed using invalid keys.

addons/bridge.py

index 803051fbdf75f534f1337d033eba5301faa492d1..c2ec8e04e3ef38ad35fb9b03a0fc1b38285045a0 100644 (file)
@@ -1663,9 +1663,9 @@ class bridge(moduleBase):
                                                   ifaceobj_getfunc,
                                                   bridgename)
         for attr, dstattr in {'bridge-pathcosts' : 'pathcost',
-                              'bridge-portprios' : 'priority',
-                              'bridge-portmcrouter' : 'mcrouter',
-                              'bridge-portmcfl' : 'mcfl' }.items():
+                              'bridge-portprios' : 'portprio',
+                              'bridge-portmcrouter' : 'portmcrouter',
+                              'bridge-portmcfl' : 'portmcfl' }.items():
             attrval = ifaceobj.get_attr_value_first(attr)
             if not attrval:
                 continue
@@ -1674,7 +1674,7 @@ class bridge(moduleBase):
                 running_attrval = self.brctlcmd.get_bridgeport_attr(
                                        bridgename, ifaceobj.name, dstattr)
 
-                if dstattr == 'mcrouter':
+                if dstattr == 'portmcrouter':
                     if not utils.is_binary_bool(attrval) and running_attrval:
                         running_attrval = utils.get_yesno_boolean(
                             utils.get_boolean_from_string(running_attrval))