clone: check is we can clone to target storage

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 13263688bc68ea908c45b40dccf8e3d91cd2155f..f7ae89dbffdd107c285b580a4335a5452715e28e 100644 (file)
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1936,6 +1936,18 @@ __PACKAGE__->register_method({
 
        my $storecfg = PVE::Storage::config();
 
+       if ($storage) {
+           # check if storage is enabled on local node
+           PVE::Storage::storage_check_enabled($storecfg, $storage);
+           if ($target) {
+               # check if storage is available on target node
+               PVE::Storage::storage_check_node($storecfg, $storage, $target);
+               # clone only works if target storage is shared
+               my $scfg = PVE::Storage::storage_config($storecfg, $storage);
+               die "can't clone to non-shared storage '$storage'\n" if !$scfg->{shared};
+           }
+       }
+
         PVE::Cluster::check_cfs_quorum();
 
        my $running = PVE::QemuServer::check_running($vmid) || 0;

diff --git a/changelog.Debian b/changelog.Debian
index 17ce837cd3a8df047d5627c3ed1dc905de8dfaf5..ed8c2e9171fe57c41982214eb2db4aadfa5846f3 100644 (file)
--- a/changelog.Debian
+++ b/changelog.Debian
@@ -1,6 +1,8 @@
 qemu-server (3.0-10) unstable; urgency=low
 
   * fix bug #381: use PVE::Tools::next_migrate_port()
+  
+  * clone: check is we can clone to target storage
 
  -- Proxmox Support Team <support@proxmox.com>  Mon, 13 May 2013 07:31:47 +0200