]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
libertas_tf: don't set URB_ZERO_PACKET on IN USB transfer
authorLubomir Rintel <lkundrak@v3.sk>
Sun, 10 Feb 2019 19:47:49 +0000 (20:47 +0100)
committerSeth Forshee <seth.forshee@canonical.com>
Mon, 25 Mar 2019 15:45:15 +0000 (10:45 -0500)
BugLink: https://bugs.launchpad.net/bugs/1821607
commit 607076a904c435f2677fadaadd4af546279db68b upstream.

It doesn't make sense and the USB core warns on each submit of such
URB, easily flooding the message buffer with tracebacks.

Analogous issue was fixed in regular libertas driver in commit 6528d8804780
("libertas: don't set URB_ZERO_PACKET on IN USB transfer").

Cc: stable@vger.kernel.org
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/net/wireless/marvell/libertas_tf/if_usb.c

index 789337ea676acd506cf9829bb5f7dba00ec2f6dc..6ede6168bd85a2b98c1fb7b2246571b93f0ad2ce 100644 (file)
@@ -433,8 +433,6 @@ static int __if_usb_submit_rx_urb(struct if_usb_card *cardp,
                          skb_tail_pointer(skb),
                          MRVDRV_ETH_RX_PACKET_BUFFER_SIZE, callbackfn, cardp);
 
-       cardp->rx_urb->transfer_flags |= URB_ZERO_PACKET;
-
        lbtf_deb_usb2(&cardp->udev->dev, "Pointer for rx_urb %p\n",
                cardp->rx_urb);
        ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);