]> git.proxmox.com Git - mirror_novnc.git/commitdiff
Remove very legacy mouse event handling
authorPierre Ossman <ossman@cendio.se>
Wed, 10 Jun 2020 10:56:50 +0000 (12:56 +0200)
committerSamuel Mannehed <samuel@cendio.se>
Fri, 12 Jun 2020 07:18:46 +0000 (09:18 +0200)
This is only needed on such ancient versions of Internet Explorer that
it wouldn't satisfy our other requirements anyway.

core/input/mouse.js
tests/test.mouse.js

index 4d0156698bc35d863b99dece16e82432c93f7ca4..8c917d098b9a65c1be2b72b26932614b08de3639 100644 (file)
@@ -42,16 +42,7 @@ export default class Mouse {
         this._updateMousePosition(e);
         let pos = this._pos;
 
-        let bmask;
-        if (e.which) {
-            /* everything except IE */
-            bmask = 1 << e.button;
-        } else {
-            /* IE including 9 */
-            bmask = (e.button & 0x1) +      // Left
-                    (e.button & 0x2) * 2 +  // Right
-                    (e.button & 0x4) / 2;   // Middle
-        }
+        let bmask = 1 << e.button;
 
         Log.Debug("onmousebutton " + (down ? "down" : "up") +
                   ", x: " + pos.x + ", y: " + pos.y + ", bmask: " + bmask);
index 9e06ff2614eb2cea4341eea7d0ea8919df21abb1..13bd0c60582d77f411d02970aa7daa44df72e1cf 100644 (file)
@@ -43,7 +43,7 @@ describe('Mouse Event Handling', function () {
                 expect(down).to.be.equal(1);
                 done();
             };
-            mouse._handleMouseDown(mouseevent('mousedown', { button: '0x01' }));
+            mouse._handleMouseDown(mouseevent('mousedown', { button: 0 }));
         });
         it('should decode mouseup events', function (done) {
             let calls = 0;
@@ -55,8 +55,8 @@ describe('Mouse Event Handling', function () {
                     done();
                 }
             };
-            mouse._handleMouseDown(mouseevent('mousedown', { button: '0x01' }));
-            mouse._handleMouseUp(mouseevent('mouseup', { button: '0x01' }));
+            mouse._handleMouseDown(mouseevent('mousedown', { button: 0 }));
+            mouse._handleMouseUp(mouseevent('mouseup', { button: 0 }));
         });
         it('should decode mousemove events', function (done) {
             const mouse = new Mouse(target);