]> git.proxmox.com Git - mirror_qemu.git/commitdiff
spapr: set vsmt to MAX(8, smp_threads)
authorLaurent Vivier <lvivier@redhat.com>
Fri, 9 Feb 2018 08:18:58 +0000 (09:18 +0100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Sat, 10 Feb 2018 09:22:02 +0000 (20:22 +1100)
We ignore silently the value of smp_threads when we set
the default VSMT value, and if smp_threads is greater than VSMT
kernel is going into trouble later.

Fixes: 8904e5a750
("spapr: Adjust default VSMT value for better migration compatibility")

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr.c

index 96515036e669af9ea599fe8f40a675773dea0822..9f29434819bda1b1d12e5caede4dc8c8367d7b7f 100644 (file)
@@ -2310,7 +2310,7 @@ static void spapr_set_vsmt_mode(sPAPRMachineState *spapr, Error **errp)
          * the value that we'd get with KVM on POWER8, the
          * overwhelmingly common case in production systems.
          */
-        spapr->vsmt = 8;
+        spapr->vsmt = MAX(8, smp_threads);
     }
 
     /* KVM: If necessary, set the SMT mode: */