]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
mtd: rawnand: Leave chip->IO_ADDR_{R, W} to NULL when unused
authorBoris Brezillon <boris.brezillon@bootlin.com>
Thu, 6 Sep 2018 22:38:33 +0000 (00:38 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 3 Oct 2018 09:12:25 +0000 (11:12 +0200)
There's no point in poisoning the ->IO_ADDR_{R,W}, a NULL pointer
is just as good to detect unexpected ->IO_ADDR_{R,W} usage.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/brcmnand/brcmnand.c
drivers/mtd/nand/raw/socrates_nand.c

index fee40a3ce5d241f122730521bea0f1c091ddd073..851db4a7d3e4eb06e80f7b3e9a6405a8c673ff6d 100644 (file)
@@ -2270,9 +2270,6 @@ static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)
        mtd->owner = THIS_MODULE;
        mtd->dev.parent = &pdev->dev;
 
-       chip->IO_ADDR_R = (void __iomem *)0xdeadbeef;
-       chip->IO_ADDR_W = (void __iomem *)0xdeadbeef;
-
        chip->cmd_ctrl = brcmnand_cmd_ctrl;
        chip->cmdfunc = brcmnand_cmdfunc;
        chip->waitfunc = brcmnand_waitfunc;
index 64ea9a014054cff9935d623e1f5f03f3abb65ee3..aa42b4ea4d23043981859ef97f1d09d74cec36bb 100644 (file)
@@ -152,10 +152,6 @@ static int socrates_nand_probe(struct platform_device *ofdev)
        mtd->name = "socrates_nand";
        mtd->dev.parent = &ofdev->dev;
 
-       /*should never be accessed directly */
-       nand_chip->IO_ADDR_R = (void *)0xdeadbeef;
-       nand_chip->IO_ADDR_W = (void *)0xdeadbeef;
-
        nand_chip->cmd_ctrl = socrates_nand_cmd_ctrl;
        nand_chip->read_byte = socrates_nand_read_byte;
        nand_chip->write_buf = socrates_nand_write_buf;