]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
brcmfmac: remove unnecessary strlcpy() upon obtaining "ver" iovar
authorArend van Spriel <arend.vanspriel@broadcom.com>
Thu, 11 Jul 2019 09:05:12 +0000 (11:05 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 24 Jul 2019 11:51:26 +0000 (14:51 +0300)
Recently a strcpy() was replaced by strlcpy(). However, the strcpy()
was not needed in the first place. So removing that line of code.

Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c

index aa89d620ee5d47d0d4ddef8e97a051a47b7472c3..dec25e4156199eb134997b9a3684bc9d8eb5937c 100644 (file)
@@ -258,7 +258,6 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp)
 
        /* query for 'ver' to get version info from firmware */
        memset(buf, 0, sizeof(buf));
-       strlcpy(buf, "ver", sizeof(buf));
        err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf));
        if (err < 0) {
                bphy_err(drvr, "Retrieving version information failed, %d\n",