]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: dsa: sja1105: flower: validate control flags
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>
Wed, 17 Apr 2024 14:44:12 +0000 (14:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 19 Apr 2024 00:08:37 +0000 (17:08 -0700)
This driver currently doesn't support any control flags.

Use flow_rule_match_has_control_flags() to check for control flags,
such as can be set through `tc flower ... ip_flags frag`.

In case any control flags are masked, flow_rule_match_has_control_flags()
sets a NL extended error message, and we return -EOPNOTSUPP.

Only compile-tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Link: https://lore.kernel.org/r/20240417144413.104257-1-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/sja1105/sja1105_flower.c

index 9e8ca182c722b0334d87fce1956ec97f10c22a22..05d8ed3121e7fb81380e3d4f597c1f5b77b45181 100644 (file)
@@ -214,6 +214,9 @@ static int sja1105_flower_parse_key(struct sja1105_private *priv,
                return -EOPNOTSUPP;
        }
 
+       if (flow_rule_match_has_control_flags(rule, extack))
+               return -EOPNOTSUPP;
+
        if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {
                struct flow_match_basic match;