zebra: TODO for handling upper level nhe_id passing

We need to handle refcnt differently if we ever start making
upper level protocols aware of nhg_hash_entry IDs.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>

diff --git a/zebra/zebra_rib.c b/zebra/zebra_rib.c
index 6827be70724ece9b1bdfdb70392c71b1dd42f49d..c89033b18c724f459150fbef8eea5bfafbf8d00f 100644 (file)
--- a/zebra/zebra_rib.c
+++ b/zebra/zebra_rib.c
@@ -2769,7 +2769,13 @@ int rib_add_multipath(afi_t afi, safi_t safi, struct prefix *p,
                }
        }
 
-       /* Attach the re to the nhe's nexthop group */
+       /*
+        * Attach the re to the nhe's nexthop group.
+        *
+        * TODO: This will need to change when we start getting IDs from upper
+        * level protocols, as the refcnt might be wrong, since it checks
+        * if old_id != new_id.
+        */
        zebra_nhg_re_update_ref(re, nhe);
 
        /* Make it sure prefixlen is applied to the prefix. */