]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
media: cx88: make const arrays default_addr_list and pvr2000_addr_list static
authorColin Ian King <colin.king@canonical.com>
Thu, 2 Nov 2017 17:16:59 +0000 (13:16 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 7 Nov 2017 09:02:53 +0000 (04:02 -0500)
Don't populate arrays default_addr_list and pvr2000_addr_list on the
stack but instead make them static. Makes the object code smaller by
over 340 bytes:

Before:
   text    data     bss     dec     hex filename
  12520    2800      64   15384    3c18 drivers/media/pci/cx88/cx88-input.o

After:
   text    data     bss     dec     hex filename
  12142    2832      64   15038    3abe drivers/media/pci/cx88/cx88-input.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/cx88/cx88-input.c

index e02449bf20414c607d6b440426bbfd18aa521f46..4e9953e61a12e6b3350fece369fccf4b29b0bd3b 100644 (file)
@@ -593,11 +593,11 @@ static int get_key_pvr2000(struct IR_i2c *ir, enum rc_proto *protocol,
 void cx88_i2c_init_ir(struct cx88_core *core)
 {
        struct i2c_board_info info;
-       const unsigned short default_addr_list[] = {
+       static const unsigned short default_addr_list[] = {
                0x18, 0x6b, 0x71,
                I2C_CLIENT_END
        };
-       const unsigned short pvr2000_addr_list[] = {
+       static const unsigned short pvr2000_addr_list[] = {
                0x18, 0x1a,
                I2C_CLIENT_END
        };