]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
swiotlb-xen: fix late init retry
authorJan Beulich <jbeulich@suse.com>
Tue, 7 Sep 2021 12:04:47 +0000 (14:04 +0200)
committerJuergen Gross <jgross@suse.com>
Wed, 15 Sep 2021 06:42:04 +0000 (08:42 +0200)
The commit referenced below removed the assignment of "bytes" from
xen_swiotlb_init() without - like done for xen_swiotlb_init_early() -
adding an assignment on the retry path, thus leading to excessively
sized allocations upon retries.

Fixes: 2d29960af0be ("swiotlb: dynamically allocate io_tlb_default_mem")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: stable@vger.kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/778299d6-9cfd-1c13-026e-25ee5d14ecb3@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/swiotlb-xen.c

index 99d518526eaf5c12c5c743f399d9a0ad65cc3ab9..dbb18dc956f34274dc32ad8378ecd83ea365dd35 100644 (file)
@@ -211,8 +211,8 @@ error:
        if (repeat--) {
                /* Min is 2MB */
                nslabs = max(1024UL, (nslabs >> 1));
-               pr_info("Lowering to %luMB\n",
-                       (nslabs << IO_TLB_SHIFT) >> 20);
+               bytes = nslabs << IO_TLB_SHIFT;
+               pr_info("Lowering to %luMB\n", bytes >> 20);
                goto retry;
        }
        pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc);