]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
wcn36xx: fix incorrect assignment to msg_body.min_ch_time
authorColin Ian King <colin.king@canonical.com>
Fri, 29 Dec 2017 09:07:31 +0000 (09:07 +0000)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 9 Jan 2018 08:19:39 +0000 (10:19 +0200)
The second assignment to msg_body.min_ch_time is incorrect, it
should actually be to msg_body.max_ch_time.

Thanks to Bjorn Andersson for identifying the correct way to fix
this as my original fix was incorrect.

Detected by CoverityScan, CID#1463042 ("Unused Value")

Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/wcn36xx/smd.c

index 2914618a03359742915974de895ede300b977ce0..2a4871ca9c7287f9eacc96df6d1d261aba4df3e2 100644 (file)
@@ -626,7 +626,7 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
 
        msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
        msg_body.min_ch_time = 30;
-       msg_body.min_ch_time = 100;
+       msg_body.max_ch_time = 100;
        msg_body.scan_hidden = 1;
        memcpy(msg_body.mac, vif->addr, ETH_ALEN);
        msg_body.p2p_search = vif->p2p;