]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ASoC: codecs: wcd938x: fix returnvar.cocci warnings
authorkernel test robot <lkp@intel.com>
Tue, 29 Jun 2021 13:29:09 +0000 (21:29 +0800)
committerMark Brown <broonie@kernel.org>
Sun, 11 Jul 2021 22:48:36 +0000 (23:48 +0100)
sound/soc/codecs/wcd938x.c:1628:5-8: Unneeded variable: "ret". Return "0" on line 1656
sound/soc/codecs/wcd938x.c:1871:5-8: Unneeded variable: "ret". Return "0" on line 1907

 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 045442228868 ("ASoC: codecs: wcd938x: add audio routing and Kconfig")
CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
Link: https://lore.kernel.org/r/20210629132909.GA7935@233d919f385f
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd938x.c

index 78b76eceff8fa2fcadb5d455104275fe4594695a..5fd708e013f98bb7957ae53f8201a2f833b18b75 100644 (file)
@@ -1623,7 +1623,6 @@ static int wcd938x_codec_aux_dac_event(struct snd_soc_dapm_widget *w,
 {
        struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
        struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
-       int ret = 0;
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
@@ -1651,7 +1650,7 @@ static int wcd938x_codec_aux_dac_event(struct snd_soc_dapm_widget *w,
                                WCD938X_ANA_RX_DIV4_CLK_EN_MASK, 0);
                break;
        }
-       return ret;
+       return 0;
 
 }
 
@@ -1866,7 +1865,6 @@ static int wcd938x_codec_enable_aux_pa(struct snd_soc_dapm_widget *w,
        struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
        struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);
        int hph_mode = wcd938x->hph_mode;
-       int ret = 0;
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
@@ -1902,7 +1900,7 @@ static int wcd938x_codec_enable_aux_pa(struct snd_soc_dapm_widget *w,
                                                      WCD938X_EN_CUR_DET_MASK, 1);
                break;
        }
-       return ret;
+       return 0;
 }
 
 static int wcd938x_codec_enable_ear_pa(struct snd_soc_dapm_widget *w,