]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
i40e: remove unnecessary i variable causing -Wshadow warning
authorJacob Keller <jacob.e.keller@intel.com>
Tue, 31 Jul 2018 10:41:44 +0000 (03:41 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 7 Aug 2018 19:20:00 +0000 (12:20 -0700)
Commit c61c8fe1d592 ("i40e: Implement an ethtool private flag to stop
LLDP in FW") added an extra for-loop which added a shadowing 'i'
variable as the index.

However, the local variable i already exists, and we already use it as
a loop index. Additionally, at this point, there is no further use of
the variable, so it's safe to simply overwrite the variable contents.

This fixes a -Wshadow warning which has started being enabled on some
distributions

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Patryk Malek <patryk.malek@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_ethtool.c

index 9c380c0b02024e6513d19be2ae683c08d45b3943..12d279a6eae8feeea11943f7749b9a0b82007e04 100644 (file)
@@ -4642,7 +4642,6 @@ flags_complete:
        if (changed_flags & I40E_FLAG_DISABLE_FW_LLDP) {
                if (pf->flags & I40E_FLAG_DISABLE_FW_LLDP) {
                        struct i40e_dcbx_config *dcbcfg;
-                       int i;
 
                        i40e_aq_stop_lldp(&pf->hw, true, NULL);
                        i40e_aq_set_dcb_parameters(&pf->hw, true, NULL);