]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
usb: gadget: mv_udc_core: fix PHY error handling
authorFelipe Balbi <balbi@ti.com>
Fri, 15 Mar 2013 08:54:59 +0000 (10:54 +0200)
committerFelipe Balbi <balbi@ti.com>
Mon, 18 Mar 2013 09:18:28 +0000 (11:18 +0200)
PHY layer no longer returns NULL. It will
return -ENXIO when PHY layer isn't enabled
and we can use that to bail out instead of
request a probe deferral.

Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/mv_udc_core.c

index d550b2129133bc1cf6d45bfb4a1070ad98d16eed..9a68c051a5a843864292fe4420693e18bb87f3cd 100644 (file)
@@ -2127,16 +2127,19 @@ static int mv_udc_probe(struct platform_device *pdev)
 
        udc->dev = pdev;
 
-#if IS_ENABLED(CONFIG_USB_PHY)
        if (pdata->mode == MV_USB_MODE_OTG) {
                udc->transceiver = devm_usb_get_phy(&pdev->dev,
                                        USB_PHY_TYPE_USB2);
-               if (IS_ERR_OR_NULL(udc->transceiver)) {
+               if (IS_ERR(udc->transceiver)) {
+                       retval = PTR_ERR(udc->transceiver);
+
+                       if (retval == -ENXIO)
+                               return retval;
+
                        udc->transceiver = NULL;
-                       return -ENODEV;
+                       return -EPROBE_DEFER;
                }
        }
-#endif
 
        udc->clknum = pdata->clknum;
        for (clk_i = 0; clk_i < udc->clknum; clk_i++) {