]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon
authorColin Ian King <colin.king@canonical.com>
Tue, 12 Nov 2019 13:05:23 +0000 (13:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Nov 2019 19:29:20 +0000 (11:29 -0800)
There is a stray semicolon in an if statement that will cause a dev_err
message to be printed unconditionally. Fix this by removing the stray
semicolon.

Addresses-Coverity: ("Stay semicolon")
Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c

index e8bf6ac1e0f4be6673cdad33fb8a5fa3ad619a37..3bd9885291782981cd27d764885b4e08adf4dfa1 100644 (file)
@@ -5317,7 +5317,7 @@ static void mv88e6xxx_port_mirror_del(struct dsa_switch *ds, int port,
                if (chip->info->ops->set_egress_port(chip,
                                                     direction,
                                                     dsa_upstream_port(ds,
-                                                                      port)));
+                                                                      port)))
                        dev_err(ds->dev, "failed to set egress port\n");
        }