rsi: release skb if rsi_prepare_beacon fails

BugLink: https://bugs.launchpad.net/bugs/1857158
commit d563131ef23cbc756026f839a82598c8445bc45f upstream.

In rsi_send_beacon, if rsi_prepare_beacon fails the allocated skb should
be released.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 46c9d5470dfb599fb8746c38a942a0096af65025..9e17172a17eb0c45a099529cd989a9b8d1b3428e 100644 (file)
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -1588,6 +1588,7 @@ static int rsi_send_beacon(struct rsi_common *common)
                skb_pull(skb, (64 - dword_align_bytes));
        if (rsi_prepare_beacon(common, skb)) {
                rsi_dbg(ERR_ZONE, "Failed to prepare beacon\n");
+               dev_kfree_skb(skb);
                return -EINVAL;
        }
        skb_queue_tail(&common->tx_queue[MGMT_BEACON_Q], skb);