]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
net: usb: asix_devices: fix missing return code check on call to asix_write_medium_mode
authorColin Ian King <colin.king@canonical.com>
Tue, 28 Feb 2017 11:58:22 +0000 (11:58 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Mar 2017 17:50:58 +0000 (09:50 -0800)
The call to asix_write_medium_mode is not updating the return code ret
and yet ret is being checked for an error. Fix this by assigning ret to
the return code from the call asix_write_medium_mode.

Detected by CoverityScan, CID#1357148 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/asix_devices.c

index 6e98ede997d3f08d4ac3fa967382b55e4dfc287d..0dd510604118bc8c26c5ec9a84410edbe16a4d8d 100644 (file)
@@ -346,7 +346,7 @@ static int ax88772_reset(struct usbnet *dev)
        if (ret < 0)
                goto out;
 
-       asix_write_medium_mode(dev, AX88772_MEDIUM_DEFAULT, 0);
+       ret = asix_write_medium_mode(dev, AX88772_MEDIUM_DEFAULT, 0);
        if (ret < 0)
                goto out;