media: atmel-isi: move of_node_put() to cover success branch as well

The of_node_put() was only covering the error branch but missed the
success branch so the refcount for ep which
of_graph_get_remote_port_parent() incremented on success would was
not being decremented.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c
index 85fc7b98b660b0eb18514c098c1e12a8ceabb8ae..e8db4df1e7c41c96e0b9607b8f1506d9d803357e 100644 (file)
--- a/drivers/media/platform/atmel/atmel-isi.c
+++ b/drivers/media/platform/atmel/atmel-isi.c
@@ -1111,10 +1111,9 @@ static int isi_graph_parse(struct atmel_isi *isi, struct device_node *node)
                return -EINVAL;
 
        remote = of_graph_get_remote_port_parent(ep);
-       if (!remote) {
-               of_node_put(ep);
+       of_node_put(ep);
+       if (!remote)
                return -EINVAL;
-       }
 
        /* Remote node to connect */
        isi->entity.node = remote;