]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
ftrace: Consistently restore trace function on sysctl enabling
authorJan Kiszka <jan.kiszka@siemens.com>
Tue, 26 Mar 2013 16:53:03 +0000 (17:53 +0100)
committerSteven Rostedt <rostedt@rostedt.homelinux.com>
Mon, 8 Apr 2013 16:24:22 +0000 (12:24 -0400)
If we reenable ftrace via syctl, we currently set ftrace_trace_function
based on the previous simplistic algorithm. This is inconsistent with
what update_ftrace_function does. So better call that helper instead.

Link: http://lkml.kernel.org/r/5151D26F.1070702@siemens.com
Cc: stable@vger.kernel.org
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/ftrace.c

index 6893d5a2bf086014f2919496ca7062c246935dad..cc4943c7ce6d45bc2577025de98b33b8254bfd5f 100644 (file)
@@ -4555,12 +4555,8 @@ ftrace_enable_sysctl(struct ctl_table *table, int write,
                ftrace_startup_sysctl();
 
                /* we are starting ftrace again */
-               if (ftrace_ops_list != &ftrace_list_end) {
-                       if (ftrace_ops_list->next == &ftrace_list_end)
-                               ftrace_trace_function = ftrace_ops_list->func;
-                       else
-                               ftrace_trace_function = ftrace_ops_list_func;
-               }
+               if (ftrace_ops_list != &ftrace_list_end)
+                       update_ftrace_function();
 
        } else {
                /* stopping ftrace calls (just send to ftrace_stub) */