]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/panel: ld9040: Use better magic values
authorPaul Cercueil <paul@crapouillou.net>
Sat, 8 Jul 2023 08:40:25 +0000 (10:40 +0200)
committerPaul Cercueil <paul@crapouillou.net>
Fri, 14 Jul 2023 08:11:02 +0000 (10:11 +0200)
I have no idea what the prior magic values mean, and I have no idea
what my replacement (extracted from [1]) magic values mean.

What I do know, is that these new values result in a much better
picture, where the blacks are really black (as you would expect on an
AMOLED display) instead of grey-ish.

[1]: https://github.com/dorimanx/Dorimanx-SG2-I9100-Kernel/blob/master-jelly-bean/arch/arm/mach-exynos/u1-panel.h

v2: Remove spurious new line

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230708084027.18352-2-paul@crapouillou.net
drivers/gpu/drm/panel/panel-samsung-ld9040.c

index 01eb211f32f7578389835cfb9a7e012e4c359710..f39f999c21afc57b1c6ee55b1bb1521bbc5bfb2e 100644 (file)
@@ -180,15 +180,15 @@ static void ld9040_init(struct ld9040 *ctx)
 {
        ld9040_dcs_write_seq_static(ctx, MCS_USER_SETTING, 0x5a, 0x5a);
        ld9040_dcs_write_seq_static(ctx, MCS_PANEL_CONDITION,
-               0x05, 0x65, 0x96, 0x71, 0x7d, 0x19, 0x3b, 0x0d,
-               0x19, 0x7e, 0x0d, 0xe2, 0x00, 0x00, 0x7e, 0x7d,
-               0x07, 0x07, 0x20, 0x20, 0x20, 0x02, 0x02);
+               0x05, 0x5e, 0x96, 0x6b, 0x7d, 0x0d, 0x3f, 0x00,
+               0x00, 0x32, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+               0x07, 0x05, 0x1f, 0x1f, 0x1f, 0x00, 0x00);
        ld9040_dcs_write_seq_static(ctx, MCS_DISPCTL,
-               0x02, 0x08, 0x08, 0x10, 0x10);
+               0x02, 0x06, 0x0a, 0x10, 0x10);
        ld9040_dcs_write_seq_static(ctx, MCS_MANPWR, 0x04);
        ld9040_dcs_write_seq_static(ctx, MCS_POWER_CTRL,
                0x0a, 0x87, 0x25, 0x6a, 0x44, 0x02, 0x88);
-       ld9040_dcs_write_seq_static(ctx, MCS_ELVSS_ON, 0x0d, 0x00, 0x16);
+       ld9040_dcs_write_seq_static(ctx, MCS_ELVSS_ON, 0x0f, 0x00, 0x16);
        ld9040_dcs_write_seq_static(ctx, MCS_GTCON, 0x09, 0x00, 0x00);
        ld9040_brightness_set(ctx);
        ld9040_dcs_write_seq_static(ctx, MIPI_DCS_EXIT_SLEEP_MODE);