]> git.proxmox.com Git - mirror_linux-firmware.git/commitdiff
make: separate installation and de-duplication targets
authorEmil Velikov <emil.l.velikov@gmail.com>
Tue, 15 Oct 2024 17:56:03 +0000 (18:56 +0100)
committerMario Limonciello <superm1@gmail.com>
Wed, 16 Oct 2024 15:52:59 +0000 (15:52 +0000)
For better or worse some distributions cannot have the firmware
de-duplication happen automatically.

In addition, when it was introduced it changed the default behaviour
leaving people with no firmware in their systems.

Revert to the original behaviour: in the worst case, people will have a
few MB extra of duplicate firmware, yet their systems will continue to
work.

To make things stand out, we print a message at the end of install so
that everyone can opt-in as needed.

In addition, I've went ahead and opened tentative MR/PR with Alpine,
Arch, CentOS Stream, Debian, Gentoo, informing them of this change.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Makefile

index 216dd4885b5bdf35189bbcca325fc7535acbe8f0..033e3fb671d3dd63ae984c1769a1d1876b0fea08 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -26,22 +26,23 @@ deb:
 rpm:
        ./build_packages.py --rpm
 
-install: install-nodedup
+dedup:
        ./dedup-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
 
-install-nodedup:
+install:
        install -d $(DESTDIR)$(FIRMWAREDIR)
        ./copy-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
+       @echo "Now run \"make dedup\" to de-duplicate any firmware files"
 
 install-xz:
        install -d $(DESTDIR)$(FIRMWAREDIR)
        ./copy-firmware.sh --xz $(DESTDIR)$(FIRMWAREDIR)
-       ./dedup-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
+       @echo "Now run \"make dedup\" to de-duplicate any firmware files"
 
 install-zst:
        install -d $(DESTDIR)$(FIRMWAREDIR)
        ./copy-firmware.sh --zstd $(DESTDIR)$(FIRMWAREDIR)
-       ./dedup-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
+       @echo "Now run \"make dedup\" to de-duplicate any firmware files"
 
 clean:
        rm -rf release dist