regulator: s2mpa01: Fix accidental enable of buck4 ramp delay

S2MPA01 supports enabling/disabling ramp delay only for buck[1234].
Other bucks have ramp delay enabled always.

However the bit shift for enabling buck4 ramp delay in register is equal
to 0. When ramp delay was set for the bucks unsupporting enable/disable
(buck[56789] and buck10), the ramp delay for buck4 was also enabled.

Fixes: f7b1a8dc1c1c ("regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate")
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>

diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator/s2mpa01.c
index f19a30f0fb42d8928735c2fd319b5ad45490b341..cab1a2b9efc55b471f13edd5963fd8e6ba817ffb 100644 (file)
--- a/drivers/regulator/s2mpa01.c
+++ b/drivers/regulator/s2mpa01.c
@@ -192,11 +192,15 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
        if (!ramp_enable)
                goto ramp_disable;
 
-       ret = regmap_update_bits(rdev->regmap, S2MPA01_REG_RAMP1,
-                                1 << enable_shift, 1 << enable_shift);
-       if (ret) {
-               dev_err(&rdev->dev, "failed to enable ramp rate\n");
-               return ret;
+       /* Ramp delay can be enabled/disabled only for buck[1234] */
+       if (rdev_get_id(rdev) >= S2MPA01_BUCK1 &&
+                       rdev_get_id(rdev) <= S2MPA01_BUCK4) {
+               ret = regmap_update_bits(rdev->regmap, S2MPA01_REG_RAMP1,
+                                        1 << enable_shift, 1 << enable_shift);
+               if (ret) {
+                       dev_err(&rdev->dev, "failed to enable ramp rate\n");
+                       return ret;
+               }
        }
 
        ramp_val = get_ramp_delay(ramp_delay);