]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: phy: mediatek: remove PHY mode check on MT7531
authorDENG Qingfang <dqfext@gmail.com>
Wed, 9 Feb 2022 14:39:47 +0000 (22:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Feb 2022 14:21:01 +0000 (14:21 +0000)
The function mt7531_phy_mode_supported in the DSA driver set supported
mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
for the internal PHY, so this check breaks the PHY initialization:

mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL

Remove the check to make it work again.

Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mediatek-ge.c

index b7a5ae20edd5374f975400f78765ccb05c33d8b5..68ee434f9dea31952010b808793b195698fbc344 100644 (file)
@@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
 
 static int mt7531_phy_config_init(struct phy_device *phydev)
 {
-       if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
-               return -EINVAL;
-
        mtk_gephy_config_init(phydev);
 
        /* PHY link down power saving enable */