Sanitize f_flags helpers

* pull ACC_MODE to fs.h; we have several copies all over the place
* nightmarish expression calculating f_mode by f_flags deserves a helper
too (OPEN_FMODE(flags))

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index 598237e972212b4908dd61db2824107c92c0f2f2..9f0bf13291e53de00b01fe6b12218cb4c3b9f664 100644 (file)
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -89,19 +89,11 @@ struct file *anon_inode_getfile(const char *name,
        struct qstr this;
        struct path path;
        struct file *file;
-       fmode_t mode;
        int error;
 
        if (IS_ERR(anon_inode_inode))
                return ERR_PTR(-ENODEV);
 
-       switch (flags & O_ACCMODE) {
-       case O_RDONLY: mode = FMODE_READ;               break;
-       case O_WRONLY: mode = FMODE_WRITE;              break;
-       case O_RDWR:   mode = FMODE_READ | FMODE_WRITE; break;
-       default:       return ERR_PTR(-EINVAL);
-       }
-
        if (fops->owner && !try_module_get(fops->owner))
                return ERR_PTR(-ENOENT);
 
@@ -129,7 +121,7 @@ struct file *anon_inode_getfile(const char *name,
        d_instantiate(path.dentry, anon_inode_inode);
 
        error = -ENFILE;
-       file = alloc_file(&path, mode, fops);
+       file = alloc_file(&path, OPEN_FMODE(flags), fops);
        if (!file)
                goto err_dput;
        file->f_mapping = anon_inode_inode->i_mapping;

diff --git a/fs/namei.c b/fs/namei.c
index d517f73aa36bfda9168258299230ba8b6d8d01ba..68921d9b53020d16e12021ede6188e5e642830a7 100644 (file)
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -37,8 +37,6 @@
 
 #include "internal.h"
 
-#define ACC_MODE(x) ("\000\004\002\006"[(x)&O_ACCMODE])
-
 /* [Feb-1997 T. Schoebel-Theuer]
  * Fundamental changes in the pathname lookup mechanisms (namei)
  * were necessary because of omirr.  The reason is that omirr needs

diff --git a/fs/open.c b/fs/open.c
index 6daee28f6e8febceff4dcebd6cbbb9a92614916a..040cef72bc00e46a0c58790f1c18cef7722756c8 100644 (file)
--- a/fs/open.c
+++ b/fs/open.c
@@ -828,7 +828,7 @@ static struct file *__dentry_open(struct dentry *dentry, struct vfsmount *mnt,
        struct inode *inode;
        int error;
 
-       f->f_mode = (__force fmode_t)((f->f_flags+1) & O_ACCMODE) | FMODE_LSEEK |
+       f->f_mode = OPEN_FMODE(f->f_flags) | FMODE_LSEEK |
                                FMODE_PREAD | FMODE_PWRITE;
        inode = dentry->d_inode;
        if (f->f_mode & FMODE_WRITE) {

diff --git a/include/linux/fs.h b/include/linux/fs.h
index cca191933ff6ec929d2784fc438049d1c60e0c7f..9e13b533aaef3450212dec9d989512922aaf1db5 100644 (file)
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2464,5 +2464,8 @@ int proc_nr_files(struct ctl_table *table, int write,
 
 int __init get_filesystem_list(char *buf);
 
+#define ACC_MODE(x) ("\000\004\002\006"[(x)&O_ACCMODE])
+#define OPEN_FMODE(flag) ((__force fmode_t)((flag + 1) & O_ACCMODE))
+
 #endif /* __KERNEL__ */
 #endif /* _LINUX_FS_H */

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 267e484f019817b87187c74bfa7aa12275411b0c..fc0f928167e78b49d0a96b6a4f6e15e80ed90c6b 100644 (file)
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -250,7 +250,6 @@ struct audit_context {
 #endif
 };
 
-#define ACC_MODE(x) ("\004\002\006\006"[(x)&O_ACCMODE])
 static inline int open_arg(int flags, int mask)
 {
        int n = ACC_MODE(flags);

diff --git a/security/tomoyo/file.c b/security/tomoyo/file.c
index 8346938809b133802ee5b2a2b8068659c0500495..9a6c58881c0a37562090a345f91b86afab76248a 100644 (file)
--- a/security/tomoyo/file.c
+++ b/security/tomoyo/file.c
@@ -12,7 +12,6 @@
 #include "common.h"
 #include "tomoyo.h"
 #include "realpath.h"
-#define ACC_MODE(x) ("\000\004\002\006"[(x)&O_ACCMODE])
 
 /*
  * tomoyo_globally_readable_file_entry is a structure which is used for holding