IB/rxe: Avoid NULL check when search is successful

While performing lookup in a pool, if entry is found, take the
reference right there, instead of checking again outside the loop and
save one branch.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/sw/rxe/rxe_pool.c b/drivers/infiniband/sw/rxe/rxe_pool.c
index c8598b91e454cb8efdf189bd9b17d51a328b75bd..36b53fb94a49d0c59a0ac785c1c6f5ca956598ea 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_pool.c
+++ b/drivers/infiniband/sw/rxe/rxe_pool.c
@@ -450,13 +450,12 @@ void *rxe_pool_get_index(struct rxe_pool *pool, u32 index)
                        node = node->rb_left;
                else if (elem->index < index)
                        node = node->rb_right;
-               else
+               else {
+                       kref_get(&elem->ref_cnt);
                        break;
+               }
        }
 
-       if (node)
-               kref_get(&elem->ref_cnt);
-
 out:
        read_unlock_irqrestore(&pool->pool_lock, flags);
        return node ? elem : NULL;