]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
cpufreq: qcom-hw: Fix return value check in qcom_cpufreq_hw_cpu_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 4 Mar 2021 10:04:23 +0000 (10:04 +0000)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 8 Mar 2021 10:50:07 +0000 (16:20 +0530)
In case of error, the function ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: 67fc209b527d ("cpufreq: qcom-hw: drop devm_xxx() calls from init/exit hooks")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/qcom-cpufreq-hw.c

index bee5d67a8227c45ab89bf0e100ba4a213b07ed5e..f86859bf76f11d9f68b8d64a7b33ab75e274f3d5 100644 (file)
@@ -317,9 +317,9 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
        }
 
        base = ioremap(res->start, resource_size(res));
-       if (IS_ERR(base)) {
+       if (!base) {
                dev_err(dev, "failed to map resource %pR\n", res);
-               ret = PTR_ERR(base);
+               ret = -ENOMEM;
                goto release_region;
        }