]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ASoC: img-spdif-in: Fix runtime PM imbalance on error
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Wed, 27 May 2020 08:43:24 +0000 (16:43 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 27 May 2020 13:48:53 +0000 (14:48 +0100)
pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200527084326.4131-1-dinghao.liu@zju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/img/img-spdif-in.c

index fd639f4d082ba93eff2e28460214dbbc093af7ec..46ff8a3621d5cac5754a2972b41238bfd59bbbc5 100644 (file)
@@ -753,8 +753,10 @@ static int img_spdif_in_probe(struct platform_device *pdev)
                        goto err_pm_disable;
        }
        ret = pm_runtime_get_sync(&pdev->dev);
-       if (ret < 0)
+       if (ret < 0) {
+               pm_runtime_put_noidle(&pdev->dev);
                goto err_suspend;
+       }
 
        rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
        if (IS_ERR(rst)) {