]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
perf tools: remove redundant checks from _sort__sym_cmp
authorSasha Levin <sasha.levin@oracle.com>
Thu, 20 Dec 2012 19:11:20 +0000 (14:11 -0500)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 24 Jan 2013 19:40:14 +0000 (16:40 -0300)
We already check that sym_l and sum_r are non-NULLs, no need to do it
twice.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1356030701-16284-12-git-send-email-sasha.levin@oracle.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/sort.c

index cfd1c0feb32d7da84d0b8b73b81883729fa623df..dbaded90312c94e25f50252ab9eed334b46592eb 100644 (file)
@@ -143,10 +143,8 @@ static int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r,
        if (sym_l == sym_r)
                return 0;
 
-       if (sym_l)
-               ip_l = sym_l->start;
-       if (sym_r)
-               ip_r = sym_r->start;
+       ip_l = sym_l->start;
+       ip_r = sym_r->start;
 
        return (int64_t)(ip_r - ip_l);
 }