]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
clk: tegra: tegra124-emc: Fix potential memory leak
authorYuan Can <yuancan@huawei.com>
Fri, 9 Dec 2022 09:41:24 +0000 (09:41 +0000)
committerStephen Boyd <sboyd@kernel.org>
Thu, 15 Jun 2023 01:25:51 +0000 (18:25 -0700)
The tegra and tegra needs to be freed in the error handling path, otherwise
it will be leaked.

Fixes: 2db04f16b589 ("clk: tegra: Add EMC clock driver")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20221209094124.71043-1-yuancan@huawei.com
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/tegra/clk-tegra124-emc.c

index 219c80653dbdb2e32ed9e9d0602e8b6cc5c90be7..2a6db0434281594cd5cef35d2ee8cd5f0760bacd 100644 (file)
@@ -464,6 +464,7 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
                err = load_one_timing_from_dt(tegra, timing, child);
                if (err) {
                        of_node_put(child);
+                       kfree(tegra->timings);
                        return err;
                }
 
@@ -515,6 +516,7 @@ struct clk *tegra124_clk_register_emc(void __iomem *base, struct device_node *np
                err = load_timings_from_dt(tegra, node, node_ram_code);
                if (err) {
                        of_node_put(node);
+                       kfree(tegra);
                        return ERR_PTR(err);
                }
        }