]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
stmmac: intel: unlock on error path in intel_crosststamp()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 21 Apr 2021 13:22:50 +0000 (16:22 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Apr 2021 17:27:55 +0000 (10:27 -0700)
We recently added some new locking to this function but one error path
was overlooked.  We need to drop the lock before returning.

Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

index ec140fc4a0f51acaf1ea5ee7f5213bbd6a33abeb..bd662aaf664a065766d22a9d0794dc1f7e190c65 100644 (file)
@@ -320,6 +320,7 @@ static int intel_crosststamp(ktime_t *device,
                acr_value |= PTP_ACR_ATSEN3;
                break;
        default:
+               mutex_unlock(&priv->aux_ts_lock);
                return -EINVAL;
        }
        writel(acr_value, ptpaddr + PTP_ACR);