]> git.proxmox.com Git - mirror_qemu.git/commitdiff
block: Use bdrv_drain to replace uncessary bdrv_drain_all
authorFam Zheng <famz@redhat.com>
Fri, 29 May 2015 10:53:14 +0000 (18:53 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 7 Jul 2015 13:27:14 +0000 (14:27 +0100)
There callers work on a single BlockDriverState subtree, where using
bdrv_drain() is more accurate.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c
block/snapshot.c
migration/block.c

diff --git a/block.c b/block.c
index 42eb8e36102efa6002fdbc3529b16ee042e94093..5e80336e9fc4873c049a7462d8d1190eb234021d 100644 (file)
--- a/block.c
+++ b/block.c
@@ -1841,9 +1841,9 @@ void bdrv_close(BlockDriverState *bs)
     if (bs->job) {
         block_job_cancel_sync(bs->job);
     }
-    bdrv_drain_all(); /* complete I/O */
+    bdrv_drain(bs); /* complete I/O */
     bdrv_flush(bs);
-    bdrv_drain_all(); /* in case flush left pending I/O */
+    bdrv_drain(bs); /* in case flush left pending I/O */
     notifier_list_notify(&bs->close_notifiers, bs);
 
     if (bs->drv) {
@@ -3906,7 +3906,7 @@ void bdrv_attach_aio_context(BlockDriverState *bs,
 
 void bdrv_set_aio_context(BlockDriverState *bs, AioContext *new_context)
 {
-    bdrv_drain_all(); /* ensure there are no in-flight requests */
+    bdrv_drain(bs); /* ensure there are no in-flight requests */
 
     bdrv_detach_aio_context(bs);
 
index 19395ae01413df3c85615a900540deedbb65ef85..49e143e99107b79964f5ba65e7f29fa52fb39ecb 100644 (file)
@@ -239,7 +239,7 @@ int bdrv_snapshot_delete(BlockDriverState *bs,
     }
 
     /* drain all pending i/o before deleting snapshot */
-    bdrv_drain_all();
+    bdrv_drain(bs);
 
     if (drv->bdrv_snapshot_delete) {
         return drv->bdrv_snapshot_delete(bs, snapshot_id, name, errp);
index ddb59ccf877ba6d383fbf323d0e6eb19f4a29472..ed865ed23bea60b0e74f37e8a06aeb809f73fb3c 100644 (file)
@@ -457,7 +457,7 @@ static int mig_save_device_dirty(QEMUFile *f, BlkMigDevState *bmds,
         blk_mig_lock();
         if (bmds_aio_inflight(bmds, sector)) {
             blk_mig_unlock();
-            bdrv_drain_all();
+            bdrv_drain(bmds->bs);
         } else {
             blk_mig_unlock();
         }