]> git.proxmox.com Git - mirror_qemu.git/commitdiff
elf2dmp: Don't abandon when Prcb is set to 0
authorAkihiko Odaki <akihiko.odaki@daynix.com>
Sun, 11 Jun 2023 03:34:34 +0000 (12:34 +0900)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 31 Jul 2023 10:20:30 +0000 (11:20 +0100)
Prcb may be set to 0 for some CPUs if the dump was taken before they
start. The dump may still contain valuable information for started CPUs
so don't abandon conversion in such a case.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20230611033434.14659-1-akihiko.odaki@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
contrib/elf2dmp/main.c

index 89f0c69ab0fbb3af615c230bd2928ffd3bcc2340..6d4d18501a37e4e7d1d51a2dbcbdbfb902a3c2ae 100644 (file)
@@ -316,6 +316,11 @@ static int fill_context(KDDEBUGGER_DATA64 *kdbg,
             return 1;
         }
 
+        if (!Prcb) {
+            eprintf("Context for CPU #%d is missing\n", i);
+            continue;
+        }
+
         if (va_space_rw(vs, Prcb + kdbg->OffsetPrcbContext,
                     &Context, sizeof(Context), 0)) {
             eprintf("Failed to read CPU #%d ContextFrame location\n", i);