drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp]

According to Table 13-45 of the i.MX8M Mini Reference Manual, the min
and max values for M and the frequency range for the VCO_out
calculator were incorrect.  This information was contradicted in other
parts of the mini, nano and plus manuals.  After reaching out to my
NXP Rep, when confronting him about discrepencies in the Nano manual,
he responded with:
 "Yes it is definitely wrong, the one that is part
  of the NOTE in MIPI_DPHY_M_PLLPMS register table against PMS_P,
  PMS_M and PMS_S is not correct. I will report this to Doc team,
  the one customer should be take into account is the Table 13-40
  DPHY PLL Parameters and the Note above."

These updated values also match what is used in the NXP downstream
kernel.

To fix this, make new variables to hold the min and max values of m
and the minimum value of VCO_out, and update the PMS calculator to
use these new variables instead of using hard-coded values to keep
the backwards compatibility with other parts using this driver.

Fixes: 4d562c70c4dc ("drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support")
Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Tested-by: Jagan Teki <jagan@amarulasolutions.com> # imx8mm-icore
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230526030559.326566-3-aford173@gmail.com

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 7b6d5dfc4f0d17f00170eddf5b97fbdd16e7dbbc..d0f97fd199d0ed5aacae35bdebb375cfb5600a7b 100644 (file)
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -407,6 +407,9 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = {
        .num_bits_resol = 11,
        .pll_p_offset = 13,
        .reg_values = reg_values,
+       .m_min = 41,
+       .m_max = 125,
+       .min_freq = 500,
 };
 
 static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
@@ -420,6 +423,9 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
        .num_bits_resol = 11,
        .pll_p_offset = 13,
        .reg_values = reg_values,
+       .m_min = 41,
+       .m_max = 125,
+       .min_freq = 500,
 };
 
 static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
@@ -431,6 +437,9 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
        .num_bits_resol = 11,
        .pll_p_offset = 13,
        .reg_values = reg_values,
+       .m_min = 41,
+       .m_max = 125,
+       .min_freq = 500,
 };
 
 static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
@@ -443,6 +452,9 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
        .num_bits_resol = 12,
        .pll_p_offset = 13,
        .reg_values = exynos5433_reg_values,
+       .m_min = 41,
+       .m_max = 125,
+       .min_freq = 500,
 };
 
 static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
@@ -455,6 +467,9 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
        .num_bits_resol = 12,
        .pll_p_offset = 13,
        .reg_values = exynos5422_reg_values,
+       .m_min = 41,
+       .m_max = 125,
+       .min_freq = 500,
 };
 
 static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = {
@@ -471,6 +486,9 @@ static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = {
         */
        .pll_p_offset = 14,
        .reg_values = imx8mm_dsim_reg_values,
+       .m_min = 64,
+       .m_max = 1023,
+       .min_freq = 1050,
 };
 
 static const struct samsung_dsim_driver_data *
@@ -549,12 +567,12 @@ static unsigned long samsung_dsim_pll_find_pms(struct samsung_dsim *dsi,
                        tmp = (u64)fout * (_p << _s);
                        do_div(tmp, fin);
                        _m = tmp;
-                       if (_m < 41 || _m > 125)
+                       if (_m < driver_data->m_min || _m > driver_data->m_max)
                                continue;
 
                        tmp = (u64)_m * fin;
                        do_div(tmp, _p);
-                       if (tmp < 500 * MHZ ||
+                       if (tmp < driver_data->min_freq  * MHZ ||
                            tmp > driver_data->max_freq * MHZ)
                                continue;
 

diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
index 6a37d1e079bf9fee42ede02354b12968fbe7e86b..2c20b9460c9a4abb42adf4d95775d41d14424221 100644 (file)
--- a/include/drm/bridge/samsung-dsim.h
+++ b/include/drm/bridge/samsung-dsim.h
@@ -54,11 +54,14 @@ struct samsung_dsim_driver_data {
        unsigned int has_freqband:1;
        unsigned int has_clklane_stop:1;
        unsigned int num_clks;
+       unsigned int min_freq;
        unsigned int max_freq;
        unsigned int wait_for_reset;
        unsigned int num_bits_resol;
        unsigned int pll_p_offset;
        const unsigned int *reg_values;
+       u16 m_min;
+       u16 m_max;
 };
 
 struct samsung_dsim_host_ops {