]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
tools/testing/nvdimm: Fix fallthrough warning
authorDan Williams <dan.j.williams@intel.com>
Wed, 7 Aug 2019 21:31:11 +0000 (14:31 -0700)
committerDan Williams <dan.j.williams@intel.com>
Thu, 15 Aug 2019 01:04:39 +0000 (18:04 -0700)
Use the expected 'fall through' designation to fix:

    tools/testing/nvdimm/test/nfit.c: In function ‘nd_intel_test_finish_query’:
    tools/testing/nvdimm/test/nfit.c:433:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
       fw->state = FW_STATE_UPDATED;
       ~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    tools/testing/nvdimm/test/nfit.c:435:2: note: here
      case FW_STATE_UPDATED:
      ^~~~

Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Link: https://lore.kernel.org/r/156521347159.1442374.1381360879102718899.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
tools/testing/nvdimm/test/nfit.c

index 507e6f4cbb53431bdcd2fcbbddc4c5a3f28790ad..bf6422a6af7ffb30dc0fea13d546f1f39446f010 100644 (file)
@@ -428,10 +428,9 @@ static int nd_intel_test_finish_query(struct nfit_test *t,
                        dev_dbg(dev, "%s: still verifying\n", __func__);
                        break;
                }
-
                dev_dbg(dev, "%s: transition out verify\n", __func__);
                fw->state = FW_STATE_UPDATED;
-               /* we are going to fall through if it's "done" */
+               /* fall through */
        case FW_STATE_UPDATED:
                nd_cmd->status = 0;
                /* bogus test version */