]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
IB/usnic: Fix out of bounds index check in query pkey
authorGal Pressman <galpress@amazon.com>
Mon, 7 Jan 2019 15:27:54 +0000 (17:27 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 4959d5da5737dd804255c75b8cea0a2929ce279a ]

The pkey table size is one element, index should be tested for > 0 instead
of > 1.

Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
Signed-off-by: Gal Pressman <galpress@amazon.com>
Acked-by: Parvi Kaustubhi <pkaustub@cisco.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/infiniband/hw/usnic/usnic_ib_verbs.c

index f76cfacd086ff129d76a74e8c0b51511dad3de2c..c5fb580993a037015e309f6f85ebf340f27c3157 100644 (file)
@@ -448,7 +448,7 @@ struct net_device *usnic_get_netdev(struct ib_device *device, u8 port_num)
 int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index,
                                u16 *pkey)
 {
-       if (index > 1)
+       if (index > 0)
                return -EINVAL;
 
        *pkey = 0xffff;