]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
USB: usbip: remove useless call in usbip_recv
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Tue, 2 Jan 2018 14:02:06 +0000 (08:02 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Jan 2018 16:05:55 +0000 (17:05 +0100)
Calling msg_data_left(&msg) is only useful for its return value,
which in this particular case is ignored.

Fix this by removing such call.

Addresses-Coverity-ID: 1427080
Fixes: 90120d15f4c3 ("usbip: prevent leaking socket pointer address in messages")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/usbip_common.c

index 7b219d9109b41282537363caa976e53c9b675332..b5af6fc7169bc4db7459fdcd073ed6d4e42d507b 100644 (file)
@@ -325,7 +325,6 @@ int usbip_recv(struct socket *sock, void *buf, int size)
        usbip_dbg_xmit("enter\n");
 
        do {
-               msg_data_left(&msg);
                sock->sk->sk_allocation = GFP_NOIO;
 
                result = sock_recvmsg(sock, &msg, MSG_WAITALL);