]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ionic: Initialize the 'lif->dbid_inuse' bitmap
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 26 Dec 2021 14:06:17 +0000 (15:06 +0100)
committerAndrea Righi <andrea.righi@canonical.com>
Fri, 21 Jan 2022 14:49:19 +0000 (15:49 +0100)
BugLink: https://bugs.launchpad.net/bugs/1956926
[ Upstream commit 140c7bc7d1195750342ea0e6ab76179499ae7cd7 ]

When allocated, this bitmap is not initialized. Only the first bit is set a
few lines below.

Use bitmap_zalloc() to make sure that it is cleared before being used.

Fixes: 6461b446f2a0 ("ionic: Add interrupts and doorbells")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Link: https://lore.kernel.org/r/6a478eae0b5e6c63774e1f0ddb1a3f8c38fa8ade.1640527506.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index 7f3322ce044c7c5d91cffd6e2002daf1a9c26e5b..6ac507ddf09afb7636c1df0c2f863bf2149564be 100644 (file)
@@ -3283,7 +3283,7 @@ int ionic_lif_init(struct ionic_lif *lif)
                return -EINVAL;
        }
 
-       lif->dbid_inuse = bitmap_alloc(lif->dbid_count, GFP_KERNEL);
+       lif->dbid_inuse = bitmap_zalloc(lif->dbid_count, GFP_KERNEL);
        if (!lif->dbid_inuse) {
                dev_err(dev, "Failed alloc doorbell id bitmap, aborting\n");
                return -ENOMEM;